Skip to content

Conversation

to-mc
Copy link
Contributor

@to-mc to-mc commented Nov 10, 2021

Issue #, if available: #694

Description of changes:

Update documentation to reflect new feature supporting composite primary keys for DynamoDB in idempotency utility.

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.


View rendered docs/utilities/idempotency.md

@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Nov 10, 2021
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 10, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2021

Codecov Report

Merging #808 (c30ed7c) into develop (6c451f7) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #808   +/-   ##
========================================
  Coverage    99.90%   99.90%           
========================================
  Files          118      118           
  Lines         5078     5107   +29     
  Branches       279      279           
========================================
+ Hits          5073     5102   +29     
  Misses           2        2           
  Partials         3        3           
Impacted Files Coverage Δ
aws_lambda_powertools/logging/logger.py 100.00% <0.00%> (ø)
aws_lambda_powertools/tracing/tracer.py 100.00% <0.00%> (ø)
aws_lambda_powertools/metrics/metrics.py 100.00% <0.00%> (ø)
aws_lambda_powertools/logging/formatter.py 100.00% <0.00%> (ø)
aws_lambda_powertools/utilities/batch/base.py 100.00% <0.00%> (ø)
...ws_lambda_powertools/middleware_factory/factory.py 100.00% <0.00%> (ø)
...s_lambda_powertools/utilities/parser/models/sns.py 100.00% <0.00%> (ø)
..._lambda_powertools/utilities/feature_flags/base.py 100.00% <0.00%> (ø)
...lambda_powertools/utilities/parser/models/apigw.py 100.00% <0.00%> (ø)
...ambda_powertools/utilities/feature_flags/schema.py 100.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c451f7...c30ed7c. Read the comment docs.

Comment on lines +311 to +313
# This exception will not cause the idempotent record to be deleted, since it
# happens after the decorated function has been successfully called
raise Exception
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition!!!

@heitorlessa heitorlessa changed the title docs: Update docs to reflect new support for composite keys in DynamoDB docs(idempotency): add support for DynamoDB composite keys Nov 12, 2021
@heitorlessa heitorlessa merged commit e09fe44 into develop Nov 12, 2021
@heitorlessa heitorlessa deleted the docs/idempotency_sortkey_update branch November 12, 2021 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants