-
Notifications
You must be signed in to change notification settings - Fork 450
docs: Fix copy to clipboard button #7270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Fix copy to clipboard button #7270
Conversation
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
e129feb
to
2632162
Compare
I need to confess I've hit a weird issue that stopped the markdown lint container image running in my pre-commit hook. I've skipped it, as I think the check is also run in the CI. Sorry for my bad behaviour 🙈 |
This commit fixes the copy to clipboard button. It moves the definition of the clipboard icon to CSS, removing the need to define it in each line, and fixing the bug affecting usage.
3d7e6ca
to
b06b798
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ConnorKirk, is this working in your environment? It doesn't seem to be working in Chrome. I don't think this is an issue with this change, but it's not working for me.
Can you please take a look?
Actually you're right! There was something weird with Chrome. This is working now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ConnorKirk! APPROVED!
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
Issue number: closes #7263
Summary
The copy to clipboard functionality did not always work as expected. Clicking the clipboard icon did not work.
This seems to be because the event handler is added to the
copyMe
class. The clipboard icon is a sibling to this class, rather than a child of the class.The typescript docs had a similar issue and we implemented the same fix
Issue: aws-powertools/powertools-lambda-typescript#3832
PR: aws-powertools/powertools-lambda-typescript#3836
Changes
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.