-
Notifications
You must be signed in to change notification settings - Fork 450
feat(event_handler): add support for Pydantic models in Query and Header types #7253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
feat(event_handler): add support for Pydantic models in Query and Header types #7253
Conversation
d584a8d
to
f9141de
Compare
Hey @tonnico ! Thanks for opening this PR, we'll review it and get back to you |
Hey @tonnico thanks a lot for working on this. I see we have some errors in the CI, can you fix them please and then we can start reviewing the code? |
I apologize to overlook I still see some improvements and will fix the remaining issues. |
131310e
to
d3b46be
Compare
@leandrodamascena I fixed code smell and the remaining typing issues. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7253 +/- ##
===========================================
+ Coverage 96.35% 96.38% +0.03%
===========================================
Files 275 275
Lines 12980 13044 +64
Branches 965 979 +14
===========================================
+ Hits 12507 12573 +66
+ Misses 366 364 -2
Partials 107 107 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @tonnico! Just a heads up, I'm reading through the code and running several end-to-end tests to make sure everything works. It might take a while, but we'll definitely try to merge as soon as possible. |
Thanks for the update. Take your time. It's a big PR, and I'd be really sad if I broke something. Thanks for taking the time to test everything. |
Issue number: closes #7039
Summary
Changes
You can use pydantic BaseModel for Query and Header.
User experience
Grouping Query or Header params in one
BaseModel
.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.