Skip to content

Conversation

tonnico
Copy link
Contributor

@tonnico tonnico commented Aug 26, 2025

Issue number: closes #7039

Summary

Changes

You can use pydantic BaseModel for Query and Header.

User experience

Grouping Query or Header params in one BaseModel.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@tonnico tonnico requested a review from a team as a code owner August 26, 2025 21:54
@tonnico tonnico requested a review from hjgraca August 26, 2025 21:54
@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 26, 2025
@tonnico tonnico force-pushed the feat/support-pydantic-in-query-form-header branch from d584a8d to f9141de Compare August 26, 2025 22:03
@anafalcao
Copy link
Contributor

Hey @tonnico ! Thanks for opening this PR, we'll review it and get back to you

@leandrodamascena
Copy link
Contributor

Hey @tonnico thanks a lot for working on this. I see we have some errors in the CI, can you fix them please and then we can start reviewing the code?

@tonnico
Copy link
Contributor Author

tonnico commented Aug 27, 2025

I apologize to overlook make pr.

I still see some improvements and will fix the remaining issues.

@tonnico tonnico force-pushed the feat/support-pydantic-in-query-form-header branch from 131310e to d3b46be Compare August 28, 2025 05:29
@tonnico
Copy link
Contributor Author

tonnico commented Aug 28, 2025

@leandrodamascena I fixed code smell and the remaining typing issues.

Copy link

codecov bot commented Aug 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.38%. Comparing base (3aada65) to head (8aa6cae).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7253      +/-   ##
===========================================
+ Coverage    96.35%   96.38%   +0.03%     
===========================================
  Files          275      275              
  Lines        12980    13044      +64     
  Branches       965      979      +14     
===========================================
+ Hits         12507    12573      +66     
+ Misses         366      364       -2     
  Partials       107      107              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@leandrodamascena
Copy link
Contributor

Hi @tonnico! Just a heads up, I'm reading through the code and running several end-to-end tests to make sure everything works. It might take a while, but we'll definitely try to merge as soon as possible.

@tonnico
Copy link
Contributor Author

tonnico commented Aug 28, 2025

Thanks for the update. Take your time. It's a big PR, and I'd be really sad if I broke something.

Thanks for taking the time to test everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
event_handlers size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: alias generator for Query, Path or Header
3 participants