Skip to content

Conversation

leandrodamascena
Copy link
Contributor

@leandrodamascena leandrodamascena commented Aug 4, 2025

Issue number: #7099

Summary

Enhances the ALB models with field descriptions and examples using Pydantic's Field() functionality. This improvement provides better documentation and metadata for ALB event models.

This change is fully backward compatible - no breaking changes to existing validation and serialization process.

Changes

Please provide a summary of what's being changed

User experience

Customers will be able to see examples and description when serializing models.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@leandrodamascena leandrodamascena requested a review from a team as a code owner August 4, 2025 16:40
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 4, 2025
@leandrodamascena leandrodamascena self-assigned this Aug 4, 2025
@leandrodamascena leandrodamascena linked an issue Aug 4, 2025 that may be closed by this pull request
2 tasks
Copy link

codecov bot commented Aug 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.35%. Comparing base (8a1854b) to head (dafeaab).
⚠️ Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7100   +/-   ##
========================================
  Coverage    96.35%   96.35%           
========================================
  Files          275      275           
  Lines        12980    12980           
  Branches       965      965           
========================================
  Hits         12507    12507           
  Misses         366      366           
  Partials       107      107           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leandrodamascena leandrodamascena requested review from dreamorosi and removed request for anafalcao August 4, 2025 16:53
Copy link

sonarqubecloud bot commented Aug 5, 2025

@leandrodamascena leandrodamascena merged commit 903bdbb into develop Aug 5, 2025
13 checks passed
@leandrodamascena leandrodamascena deleted the feat/parser-improvemodels-alb branch August 5, 2025 09:32
dcabib added a commit to dcabib/powertools-lambda-python that referenced this pull request Aug 30, 2025
Enhances the SQS parser models with field descriptions and examples using Pydantic's Field() functionality. This improvement provides better documentation and metadata for SQS event parsing, following the pattern established in PR aws-powertools#7100.

All field descriptions are based on official AWS SQS documentation and include realistic examples from actual test events.

Closes aws-powertools#7116
dcabib added a commit to dcabib/powertools-lambda-python that referenced this pull request Aug 30, 2025
Enhances the SNS parser models with field descriptions and examples using Pydantic's Field() functionality. This improvement provides better documentation and metadata for SNS event parsing, following the pattern established in PR aws-powertools#7100.

All field descriptions are based on official AWS SNS documentation and include realistic examples from actual test events.

Closes aws-powertools#7117
leandrodamascena added a commit that referenced this pull request Sep 1, 2025
…7287)

* refactor(parser): Improve SNS models with examples and descriptions

Enhances the SNS parser models with field descriptions and examples using Pydantic's Field() functionality. This improvement provides better documentation and metadata for SNS event parsing, following the pattern established in PR #7100.

All field descriptions are based on official AWS SNS documentation and include realistic examples from actual test events.

Closes #7117

* style: apply ruff formatting to SNS models

Fix CI formatting issues as requested by leandrodamascena

* style: fix line length issues in SNS models

Break long lines over 120 characters following ALB/Kinesis pattern as requested by leandrodamascena. Use parentheses for multi-line strings and break long URL examples.

* Fix styles

* Fix styles

---------

Co-authored-by: Leandro Damascena <lcdama@amazon.pt>
dcabib added a commit to dcabib/powertools-lambda-python that referenced this pull request Sep 1, 2025
Enhances the Kafka parser models with field descriptions and examples using Pydantic's Field() functionality. This improvement provides better documentation and metadata for Kafka event parsing, following the pattern established in PR aws-powertools#7100.

All field descriptions are based on official AWS MSK and Kafka documentation and include realistic examples from actual test events.

Closes aws-powertools#7118
leandrodamascena pushed a commit that referenced this pull request Sep 1, 2025
…#7293)

Enhances the Kafka parser models with field descriptions and examples using Pydantic's Field() functionality. This improvement provides better documentation and metadata for Kafka event parsing, following the pattern established in PR #7100.

All field descriptions are based on official AWS MSK and Kafka documentation and include realistic examples from actual test events.

Closes #7118
dcabib added a commit to dcabib/powertools-lambda-python that referenced this pull request Sep 1, 2025
…scriptions

Enhances the Transfer Family parser models with field descriptions and examples using Pydantic's Field() functionality. This improvement provides better documentation and metadata for Transfer Family event parsing, following the pattern established in PR aws-powertools#7100.

All field descriptions are based on official AWS Transfer Family Lambda authorizer documentation and include realistic examples from actual test events.

Closes aws-powertools#7119
leandrodamascena pushed a commit that referenced this pull request Sep 1, 2025
…scriptions (#7294)

* refactor(parser): Improve Transfer Family models with examples and descriptions

Enhances the Transfer Family parser models with field descriptions and examples using Pydantic's Field() functionality. This improvement provides better documentation and metadata for Transfer Family event parsing, following the pattern established in PR #7100.

All field descriptions are based on official AWS Transfer Family Lambda authorizer documentation and include realistic examples from actual test events.

Closes #7119

* security: fix password examples to avoid security hotspots

Replace specific password examples with placeholder format to resolve SonarQube security hotspots while maintaining documentation value.

* security: remove IP address examples as requested

Remove IP address examples from source_ip field to avoid triggering security pipelines in customer environments as requested by leandrodamascena.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tech debt: Improve documentation of Event model fields in ALB Model
2 participants