Skip to content

refactor(metrics): Improve type annotations for metrics decorator #6000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 3, 2025
Merged

refactor(metrics): Improve type annotations for metrics decorator #6000

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6f52253
Fix type annotation with metrics decorator
leandrodamascena Feb 3, 2025
c37d035
Merge branch 'develop' into fix/metrics-decorator-typing
leandrodamascena Feb 3, 2025
3a3c3ed
Merge branch 'develop' into fix/metrics-decorator-typing
leandrodamascena Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions aws_lambda_powertools/metrics/metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# NOTE: keeps for compatibility
from __future__ import annotations

from typing import TYPE_CHECKING, Any
from typing import TYPE_CHECKING, Any, Callable

from aws_lambda_powertools.metrics.provider.cloudwatch_emf.cloudwatch import AmazonCloudWatchEMFProvider

Expand Down Expand Up @@ -149,8 +149,8 @@ def log_metrics(
capture_cold_start_metric: bool = False,
raise_on_empty_metrics: bool = False,
default_dimensions: dict[str, str] | None = None,
**kwargs,
):
**kwargs: dict[str, Any],
) -> Callable[..., Any]:
return self.provider.log_metrics(
lambda_handler=lambda_handler,
capture_cold_start_metric=capture_cold_start_metric,
Expand Down
Loading