Skip to content

refactor(feature-flags): add debug for all features evaluation" #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 5, 2021
Merged

refactor(feature-flags): add debug for all features evaluation" #590

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a76582
chore: add missing debugging log for all feats
heitorlessa Aug 5, 2021
93afade
revert: autolabeler for release-drafter PR title
heitorlessa Aug 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions .github/release-drafter.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,18 +39,3 @@ template: |
## This release was made possible by the following contributors:

$CONTRIBUTORS

autolabeler:
- label: 'documentation'
title:
- '/docs.+/i'
- label: 'bug'
title:
- '/fix/i'
- label: 'feature'
title:
- '/feat.+/i'
- '/refactor.+/i'
- label: 'internal'
title:
- '/chore.+/i'
1 change: 1 addition & 0 deletions aws_lambda_powertools/utilities/feature_flags/feature_flags.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,7 @@ def get_enabled_features(self, *, context: Optional[Dict[str, Any]] = None) -> L
logger.debug(f"Failed to fetch feature flags from store, returning empty list, reason={err}")
return features_enabled

logger.debug("Evaluating all features")
for name, feature in features.items():
rules = feature.get(schema.RULES_KEY, {})
feature_default_value = feature.get(schema.FEATURE_DEFAULT_VAL_KEY)
Expand Down