Skip to content

fix(ci): inject PR_LABELS env for PR Label automation #3819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 21, 2024
Merged

fix(ci): inject PR_LABELS env for PR Label automation #3819

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
95d9d8e
fix(parameters): make cache aware of single vs multiple calls
heitorlessa Jul 25, 2023
5095182
chore: cleanup, add test for single and nested
heitorlessa Jul 25, 2023
7ba98bc
fix(ci): inject PR_LABELS env
heitorlessa Feb 21, 2024
6cc6efc
chore: init PR_LABELS env with default to prevent failure (no labels)
heitorlessa Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/scripts/constants.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ module.exports = Object.freeze({
/** @type {string} */
"PR_IS_MERGED": process.env.PR_IS_MERGED || "false",

/** @type {string} */
"PR_LABELS": process.env.PR_LABELS || "",

/** @type {string} */
"LABEL_BLOCK": "do-not-merge",

Expand Down
5 changes: 2 additions & 3 deletions .github/scripts/label_pr_based_on_title.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const { PR_NUMBER, PR_TITLE } = require("./constants")
const { PR_NUMBER, PR_TITLE, PR_LABELS } = require("./constants")

module.exports = async ({github, context, core}) => {
const FEAT_REGEX = /feat(\((.+)\))?(:.+)/
Expand All @@ -18,10 +18,9 @@ module.exports = async ({github, context, core}) => {
}

// get PR labels from env
const prLabels = process.env.PR_LABELS.replaceAll("\"", "").split(",");
const prLabels = PR_LABELS.replaceAll("\"", "").split(",");
const labelKeys = Object.keys(labels);

// Maintenance: We should keep track of modified PRs in case their titles change
let miss = 0;
try {
for (const label in labels) {
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/label_pr_on_title.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ jobs:
env:
PR_NUMBER: ${{ needs.get_pr_details.outputs.prNumber }}
PR_TITLE: ${{ needs.get_pr_details.outputs.prTitle }}
PR_LABELS: ${{ needs.get_pr_details.outputs.prLabels }}
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
# This safely runs in our base repo, not on fork
Expand Down