Skip to content

fix(event_handler): hide error details by default #3406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 23, 2023
Merged

fix(event_handler): hide error details by default #3406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion aws_lambda_powertools/event_handler/api_gateway.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1979,11 +1979,14 @@ def _call_exception_handler(self, exp: Exception, route: Route) -> Optional[Resp
exp = service_error

if isinstance(exp, RequestValidationError):
# For security reasons, we hide msg details (don't leak Python, Pydantic or file names)
errors = [{"loc": e["loc"], "type": e["type"]} for e in exp.errors()]

return self._response_builder_class(
response=Response(
status_code=HTTPStatus.UNPROCESSABLE_ENTITY,
content_type=content_types.APPLICATION_JSON,
body={"statusCode": HTTPStatus.UNPROCESSABLE_ENTITY, "message": exp.errors()},
body={"statusCode": HTTPStatus.UNPROCESSABLE_ENTITY, "detail": errors},
),
serializer=self._serializer,
route=route,
Expand Down
6 changes: 3 additions & 3 deletions tests/functional/event_handler/test_bedrock_agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,11 +121,11 @@ def claims() -> Dict[str, Any]:
assert result["response"]["httpMethod"] == "GET"
assert result["response"]["httpStatusCode"] == 422

body = result["response"]["responseBody"]["application/json"]["body"]
body = json.loads(result["response"]["responseBody"]["application/json"]["body"])
if PYDANTIC_V2:
assert "should be a valid dictionary" in body
assert body["detail"][0]["type"] == "dict_type"
else:
assert "value is not a valid dict" in body
assert body["detail"][0]["type"] == "type_error.dict"


def test_bedrock_agent_event_with_exception():
Expand Down