Skip to content

chore(ci): propagate checkout permission to nested workflows #2642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 4, 2023
Merged

chore(ci): propagate checkout permission to nested workflows #2642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a571520
chore: correct job name for pr updates requirements
heitorlessa Jul 4, 2023
1dd976e
fix(ci): propagate content read to nested workflow
heitorlessa Jul 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/label_pr_on_title.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ jobs:
get_pr_details:
permissions:
actions: read # download PR artifact
contents: read # checkout code
# Guardrails to only ever run if PR recording workflow was indeed
# run in a PR event and ran successfully
if: ${{ github.event.workflow_run.conclusion == 'success' }}
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/on_label_added.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ jobs:
get_pr_details:
permissions:
actions: read # download PR artifact
contents: read # checkout code
if: ${{ github.event.workflow_run.conclusion == 'success' }}
uses: ./.github/workflows/reusable_export_pr_details.yml
with:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/on_merged_pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ jobs:
get_pr_details:
permissions:
actions: read # download PR artifact
contents: read # checkout code
if: github.event.workflow_run.event == 'pull_request' && github.event.workflow_run.conclusion == 'success'
uses: ./.github/workflows/reusable_export_pr_details.yml
with:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/on_opened_pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ jobs:
get_pr_details:
permissions:
actions: read # download PR artifact
contents: read # checkout code
if: ${{ github.event.workflow_run.conclusion == 'success' }}
uses: ./.github/workflows/reusable_export_pr_details.yml
with:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/on_pr_updates.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ name: PR requirements
# due to limitations in GH API.

on:
pull_request:
pull_request:
types:
- opened
- labeled
Expand All @@ -26,7 +26,7 @@ on:
permissions: {} # no permission required

jobs:
fail-for-draft:
check-requirements:
runs-on: ubuntu-latest
steps:
- name: Block if it doesn't minimum requirements
Expand Down