Skip to content

Conversation

LuisValdesZero
Copy link
Contributor

@LuisValdesZero LuisValdesZero commented Feb 3, 2023

Issue number: #1891

chore(homepage): set url for end-of-support in announce block

I was working my way through the docs and I saw that the link for end-of-support-v1 was not working, I fixed it.

Signed-off-by: Luis Valdés luis@valdes.com.br

chore(homepage): set banner url for end-of-support page

Signed-off-by: Luis Valdés <luis@valdes.com.br>
@LuisValdesZero LuisValdesZero requested a review from a team as a code owner February 3, 2023 05:08
@LuisValdesZero LuisValdesZero requested review from leandrodamascena and removed request for a team February 3, 2023 05:08
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Feb 3, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 3, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Feb 3, 2023

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.
In the meantime, check out the #python channel on our AWS Lambda Powertools Discord: Invite link

@LuisValdesZero LuisValdesZero changed the title chore(homepage): set banner url for end-of-support page chore(homepage): set url for end-of-support in announce block Feb 3, 2023
@rubenfonseca rubenfonseca added the need-issue PRs that are missing related issues label Feb 3, 2023
@github-actions github-actions bot added the internal Maintenance changes label Feb 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2023

No related issues found. Please ensure there is an open issue related to this change to avoid significant delays or closure.

Copy link
Contributor

@rubenfonseca rubenfonseca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this! I've edited the PR description to add a reference to the original issue.

@rubenfonseca rubenfonseca removed do-not-merge need-issue PRs that are missing related issues labels Feb 3, 2023
@rubenfonseca rubenfonseca changed the title chore(homepage): set url for end-of-support in announce block docs(homepage): set url for end-of-support in announce block Feb 3, 2023
@rubenfonseca rubenfonseca merged commit 42cf449 into aws-powertools:develop Feb 3, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Feb 3, 2023

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!

@LuisValdesZero
Copy link
Contributor Author

Thank you for this! I've edited the PR description to add a reference to the original issue.

Thanks for adding the issue number.
Great docs btw.

heitorlessa added a commit to BakasuraRCE/aws-lambda-powertools-python that referenced this pull request Feb 7, 2023
* develop: (24 commits)
  chore(deps): bump docker/setup-buildx-action from 2.4.0 to 2.4.1 (aws-powertools#1903)
  chore(deps-dev): bump aws-cdk-lib from 2.63.0 to 2.63.2 (aws-powertools#1904)
  update changelog with latest changes
  docs(idempotency): add IAM permissions section (aws-powertools#1902)
  chore(deps-dev): bump mkdocs-material from 9.0.10 to 9.0.11 (aws-powertools#1896)
  chore(deps-dev): bump mypy-boto3-appconfig from 1.26.0.post1 to 1.26.63 (aws-powertools#1895)
  chore(maintainers): fix release workflow rename
  update changelog with latest changes
  docs(homepage): set url for end-of-support in announce block (aws-powertools#1893)
  chore(deps-dev): bump mkdocs-material from 9.0.9 to 9.0.10 (aws-powertools#1888)
  chore(deps-dev): bump mypy-boto3-s3 from 1.26.58 to 1.26.62 (aws-powertools#1889)
  chore(deps-dev): bump black from 22.12.0 to 23.1.0 (aws-powertools#1886)
  chore(deps-dev): bump aws-cdk-lib from 2.62.2 to 2.63.0 (aws-powertools#1887)
  update changelog with latest changes
  feat(metrics): add default_dimensions to single_metric (aws-powertools#1880)
  chore: update v2 layer ARN on documentation
  bump version to 2.7.1
  update changelog with latest changes
  docs(homepage): add banner for end-of-support v1 (aws-powertools#1879)
  fix(license): correction to MIT + MIT-0 (no proprietary anymore) (aws-powertools#1883)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation internal Maintenance changes size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: fix the link in the end-of-support v1 banner
2 participants