Test on shippable #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,5 +1,5 @@ | |||
| mysql: | |||
| image: autopilotpattern/mysql:latest | |||
| image: autopilotpattern/mysql | |||
Contributor
There was a problem hiding this comment.
Does this actually affect the tests, or are you eliminating the explicit :latest, since it's assumed anyway?
Contributor
Author
There was a problem hiding this comment.
Just eliminating the explicit :latest but at some point I need to figure out how to get the test rig to add the build identifier here so that we're testing the build we just created and not some arbitrary "latest"
| -w /src test $(TEST_RUN) tests.py | ||
| ## Pushes the application container image to the Docker Hub | ||
| ship: | ||
| docker push autopilotpattern/mysql:$(TAG) |
Contributor
Author
There was a problem hiding this comment.
@misterbisson should we be simultaneously pushing the :latest tag here, do you think?
Contributor
There was a problem hiding this comment.
Yes, agreed: ship means :latest too.
Includes injecting credentials for Manta
Contributor
|
🏡 🚶 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@misterbisson this is the work-in-progress PR.