Stop replication #27
Merged
Stop replication #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a race between the onChange and health handler around stopping replication while we figure out which instance is primary. These leaves the onChange handler in an infinite loop because we previously assumed that the only errors we'd get were from the session lock. This commit breaks the loop when error code 1198 ER_SLAVE_MUST_STOP is received from mysqld, which says that replication has already been started.
| # --------------------------------------------------------- | ||
| # Top-level functions called by ContainerPilot or forked by this program | ||
|
|
||
| @debug |
Contributor
There was a problem hiding this comment.
Intended to leave this in?
Contributor
Author
There was a problem hiding this comment.
Yah. At the top of the file you'll see I did a little expanding of the information in the debug log so that interleaved events can be separated. While doing that it became obvious we needed to tag a couple more events to see the workflow properly.
Contributor
|
lgtm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a race between the onChange and health handler around stopping replication while we figure out which instance is primary. These leaves the onChange handler in an infinite loop because we previously assumed that the only errors we'd get were from the session lock.
This PR breaks the loop when error code 1198 ER_SLAVE_MUST_STOP is received from mysqld, which says that replication has already been started.
cc @misterbisson for review