-
Notifications
You must be signed in to change notification settings - Fork 45
expands CRDB new enemy section #370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
provides more detail to help customers determine which overlap strategy works best for their workload.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
159e5e2 to
7453d49
Compare
7453d49 to
634d6f7
Compare
the page was already too long
634d6f7 to
8870dc5
Compare
46506f8 to
db11eb1
Compare
tstirrat15
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| ## Usage Notes | ||
|
|
||
| - Requires a Google Cloud Account with an active Cloud Spanner instance | ||
| - Take advantage of Google's TrueTime. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this important, what does this mean for users?
|
|
||
| - Requires a Google Cloud Account with an active Cloud Spanner instance | ||
| - Take advantage of Google's TrueTime. | ||
| The Spanner driver assumes the database is linearizable and skips the transaction overlap strategy required by CockroachDB. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Spanner driver assumes the database is linearizable
is this something the user can change?
skips the transaction overlap strategy required by CockroachDB.
what does this mean? like if i'm a spicedb newbie user do i need to configure anything to prevent the New Enemy problem or am i protected by default?
miparnisari
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you bring your PR up to date with main?
ℹ️ better reviewed by commits
provides more detail to help customers
determine which overlap strategy works
best for their workload.