Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the telemetry schema to distinguish AI agent identity from CI system identity, and aligns context to represent only terminal interactivity. It also ensures telemetry is disabled by default across the full test suite.
Changes:
- Updated invocation context detection to return
(context, agent, ci_system)and emitci_systemas a separate telemetry property. - Simplified
contexttelemetry property to only"interactive"/"non-interactive". - Added a root
tests/conftest.pyto disable telemetry globally during tests and removed redundant integration-test-only disabling.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| astro-airflow-mcp/src/astro_airflow_mcp/telemetry.py | Updates context detection and adds ci_system to MCP tool-call telemetry properties. |
| astro-airflow-mcp/src/astro_airflow_mcp/cli/telemetry.py | Threads ci_system into CLI telemetry properties. |
| astro-airflow-mcp/tests/test_telemetry.py | Updates tests for the new (context, agent, ci_system) tuple and validates combined agent+CI detection. |
| astro-airflow-mcp/tests/test_telemetry_middleware.py | Updates middleware telemetry tests for the new context tuple and context semantics. |
| astro-airflow-mcp/tests/integration/conftest.py | Removes per-suite telemetry disabling in favor of global test configuration. |
| astro-airflow-mcp/tests/conftest.py | Disables telemetry for all tests via AF_TELEMETRY_DISABLED=1. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
kaxil
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agentandci_systemtelemetry fields: Previously a singleagentproperty held both AI agent names and CI system names, making them mutually exclusive. Nowagentandci_systemare independent fields — both populate when an agent runs inside CI (e.g. Claude Code in GitHub Actions).contextfield: Now only reflects terminal type (interactive/non-interactive), no longer duplicates agent/CI info withagentorcivalues.tests/conftest.pythat setsAF_TELEMETRY_DISABLED=1so no test suite fires real telemetry events.Example event shape
{ "context": "non-interactive", "agent": "claude-code", "ci_system": "github-actions", "command": "dags list", ... }