This repository was archived by the owner on May 29, 2019. It is now read-only.
Workaround for EF double quoting issue which causes Musicstore#105#119
Merged
kanchanm merged 3 commits intoaspnet:masterfrom May 21, 2014
Merged
Workaround for EF double quoting issue which causes Musicstore#105#119kanchanm merged 3 commits intoaspnet:masterfrom
kanchanm merged 3 commits intoaspnet:masterfrom
Conversation
There was a problem hiding this comment.
I wouldn't block on this but we could update the name of the parameter, any variables, etc. to orderHeader.
Author
There was a problem hiding this comment.
Yeah, i agree and considered that but didn't want to make the workaround too heavy so unless there is strong concern here I would leave it as is.
|
|
kanchanm
added a commit
that referenced
this pull request
May 21, 2014
Workaround for EF double quoting issue which causes Musicstore#105
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix is same as the one in PR here #110 + some naming feedback from Diego. It did not get checked in earlier. Given this bug still exists in Alpha and this breaks music store scenario we want to check this into Master. Since EF team planned to fix the bug soon anyways we don't plan to patch dev branch with this.
@divega, @mgirgin please review
P.S. please ignore the branch naming. I started with another change but it got covered by changes Prabu was making but the name stayed :-).