Export Mutagen costs. Fix Mutagel conversion rates. Tune JSON encoding. Don't clean wiki.species names.#136
Closed
Export Mutagen costs. Fix Mutagel conversion rates. Tune JSON encoding. Don't clean wiki.species names.#136
Conversation
This has been stashed for a very long time, originating from one of the first explorer notes branches. I don't see a reason why this wouldn't be merged, nor do I remember any from back when this was first discussed.
coldino
approved these changes
Nov 29, 2021
Member
coldino
left a comment
coldino
left a comment
There was a problem hiding this comment.
LGTM pending testing during merge
|
|
||
| # DevKit Unverified | ||
| bUsesGender = uebools(True) | ||
| MutagenBaseCost = uefloats(-1) |
Member
There was a problem hiding this comment.
Can we get this verified before merge?
| '''JSON with added beautification!''' | ||
| if pretty: | ||
| json_string = json.dumps(data, indent='\t') | ||
| json_string = json.dumps(data, ensure_ascii=False, indent='\t') |
Member
There was a problem hiding this comment.
Would rather this was a separate change, so I'll cherry-pick before merge.
| # Formula extracted from PrimalItemConsumable_Mutagen_C's scripts | ||
| # Vultures cannot use Mutagen as it can't enter their inventories. | ||
| # IsRobot and IsVehicle banned from Mutagen in v329.51. | ||
| if species.DinoNameTag[0] != 'Vulture' and not species.bIsRobot[0] and not species.bIsVehicle[0]: |
Member
There was a problem hiding this comment.
As discussed, I'd like to get the Vulture tag removed from the code and replaced by a configurable list in overrides. Please create an issue for this work to be done in future.
Member
|
This was merged in two pieces. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.