Added a "shuffle discard into deck" button to playermats #877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Chr1Z93
commented
Sep 18, 2024
Chr1Z93
commented
Chr1Z93
requested review from
BootleggerFinn,
Entrox-Licher,
Tikatoy,
argonui and
dscarpac
as code owners
Chr1Z93
commented
Sep 18, 2024
dscarpac
requested changes
Sep 23, 2024
Collaborator
dscarpac
left a comment
dscarpac
left a comment
There was a problem hiding this comment.
(1) Probably needs some messages when the button is clicked, even if it fails (e.g. nothing in the discard)
(2) When the deck is empty, the button needs to flip the deck prior to shuffling. (As is, the 'new' deck remains face-up)
dscarpac
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.