Skip to content

Updated player card panel #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dscarpac merged 7 commits into from
May 29, 2024
Merged

Updated player card panel #698

dscarpac merged 7 commits into from
May 29, 2024

Conversation

@Chr1Z93
Copy link
Collaborator

@Chr1Z93 Chr1Z93 commented May 24, 2024 •
edited
Loading

  • Some code maintenance
  • added conditional button to spawn cards without cycle (usually fan-made cards)

TODO:

  • handle investigators / cards without level (postponed since the PR is big enough already)

@Chr1Z93 Chr1Z93 added enhancement New feature or request optimization Improving something existing labels May 24, 2024
@Chr1Z93 Chr1Z93 marked this pull request as ready for review May 28, 2024 22:48
@dscarpac dscarpac merged commit 17326de into main May 29, 2024
@dscarpac dscarpac deleted the card-panel branch May 29, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dscarpac dscarpac dscarpac approved these changes

@argonui argonui Awaiting requested review from argonui argonui is a code owner

@Tikatoy Tikatoy Awaiting requested review from Tikatoy Tikatoy is a code owner

@BootleggerFinn BootleggerFinn Awaiting requested review from BootleggerFinn BootleggerFinn is a code owner

@Entrox-Licher Entrox-Licher Awaiting requested review from Entrox-Licher Entrox-Licher is a code owner

Assignees

No one assigned

Labels

enhancement New feature or request optimization Improving something existing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Chr1Z93 @dscarpac