Skip to content

Campaign Exporter Improvements #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Chr1Z93 merged 17 commits into from
Jan 15, 2024
Merged

Campaign Exporter Improvements #533

Chr1Z93 merged 17 commits into from
Jan 15, 2024

Conversation

@Entrox-Licher
Copy link
Collaborator

@Entrox-Licher Entrox-Licher commented Jan 8, 2024

Added support for Additional Player Cards bag (still needs latency improvements), custom trauma getting, importing on collision, and fixed the tour bug

@Entrox-Licher
Bug Fixes & Improvements
f53f7fd 
Added support for Additional Player Cards bag (still needs latency improvements), custom trauma getting, importing on collision, and fixed the tour bug
@Entrox-Licher
Performance Improvement
1bc78bd
Chr1Z93
Chr1Z93 requested changes Jan 8, 2024
View reviewed changes
@Chr1Z93 Chr1Z93 self-assigned this Jan 9, 2024
@Chr1Z93 Chr1Z93 linked an issue Jan 9, 2024 that may be closed by this pull request
Importer/Exporter crash on tour deletion #503
Closed
Chr1Z93
Chr1Z93 reviewed Jan 9, 2024
View reviewed changes
@Entrox-Licher
Copy link
Collaborator Author

Entrox-Licher commented Jan 10, 2024

This should be ready now! Any tips on how to implement the coroutine we discussed to reduce freezing/stuttering?

@Entrox-Licher Entrox-Licher requested a review from Chr1Z93 January 10, 2024 02:52
@Chr1Z93
Copy link
Collaborator

Chr1Z93 commented Jan 10, 2024 •
edited
Loading

This should be ready now! Any tips on how to implement the coroutine we discussed to reduce freezing/stuttering?

Is additionalIndex = additionalIndex.getJSON() the only line that introduces freezing?
If so, then we can't really help it. If not, then you could use a coroutine to gather all the data (with some delays between each step).

Chr1Z93
Chr1Z93 requested changes Jan 14, 2024
View reviewed changes
@Chr1Z93 Chr1Z93 added the optimization Improving something existing label Jan 15, 2024
@Entrox-Licher Entrox-Licher requested a review from Chr1Z93 January 15, 2024 21:45
@Chr1Z93 Chr1Z93 merged commit 197bb9a into argonui:main Jan 15, 2024
@Entrox-Licher Entrox-Licher deleted the campaign-exporter-fix branch January 16, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Chr1Z93 Chr1Z93 Chr1Z93 approved these changes

@argonui argonui Awaiting requested review from argonui argonui is a code owner

@Tikatoy Tikatoy Awaiting requested review from Tikatoy Tikatoy is a code owner

@BootleggerFinn BootleggerFinn Awaiting requested review from BootleggerFinn BootleggerFinn is a code owner

Assignees

@Chr1Z93 Chr1Z93

Labels

optimization Improving something existing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Importer/Exporter crash on tour deletion

2 participants

@Entrox-Licher @Chr1Z93