Skip to content

Standardize repository structure #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Mar 23, 2021
Merged

Standardize repository structure #17

merged 29 commits into from
Mar 23, 2021

Conversation

@silvanocerza
Copy link
Contributor

@silvanocerza silvanocerza commented Mar 17, 2021 •
edited by per1234
Loading

This PR updates the repository to be in line with the rest of repositories owned by the Tooling Team.

check-certificates.yml will fail after we merge this since some certicates in certs folder are outdated.

We need to add the following secrets for the release.yml and check-notarization-certificates.yml workflows to work correctly.

INSTALLER_CERT_MAC_P12
INSTALLER_CERT_MAC_PASSWORD
AC_USERNAME
AC_PASSWORD

@silvanocerza silvanocerza added the topic: infrastructure Related to project infrastructure label Mar 17, 2021
@silvanocerza silvanocerza requested review from per1234 and rsora March 17, 2021 16:49
@silvanocerza silvanocerza self-assigned this Mar 17, 2021
per1234
per1234 requested changes Mar 18, 2021
View reviewed changes
@silvanocerza
Copy link
Contributor Author

@per1234 I think I fixed all the things you pointed out, let me know if there's any issue.

per1234
per1234 requested changes Mar 19, 2021
View reviewed changes
@silvanocerza
Copy link
Contributor Author

Updated again.

per1234
per1234 requested changes Mar 22, 2021
View reviewed changes
per1234
per1234 reviewed Mar 22, 2021
View reviewed changes
per1234
per1234 approved these changes Mar 22, 2021
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All working for me in my fork now. Thanks Silvano! It's very exciting to see this improved automation for the FirmwareUpdater project.

@silvanocerza silvanocerza merged commit 5a37bc1 into main Mar 23, 2021
@silvanocerza silvanocerza deleted the scerza/repo-enhance branch March 23, 2021 11:13
@per1234 per1234 mentioned this pull request Jun 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@per1234 per1234 per1234 approved these changes

@rsora rsora Awaiting requested review from rsora

Assignees

@silvanocerza silvanocerza

Labels

topic: infrastructure Related to project infrastructure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@silvanocerza @per1234