Skip to content

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Feb 1, 2022

Closes #127

@umbynos umbynos added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Feb 1, 2022
@umbynos umbynos self-assigned this Feb 1, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2022

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 11.04%. Comparing base (c061e88) to head (1a77a29).
⚠️ Report is 116 commits behind head on main.

Files with missing lines Patch % Lines
cli/firmware/list.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
- Coverage   11.04%   11.04%   -0.01%     
==========================================
  Files          21       21              
  Lines        1810     1811       +1     
==========================================
  Hits          200      200              
- Misses       1551     1552       +1     
  Partials       59       59              
Flag Coverage Δ
unit 11.04% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes #127 for me.
Thanks Umberto!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: code Related to content of the project itself type: enhancement Proposed improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't panic on firmware list without Internet connection

4 participants