Now compile --only-compilation-database will run all pre-* hooks
#1549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some platforms make sketch preparation see arduino#1547 Fix arduino#1547
cmaglie
force-pushed
the
fix-compile-db
branch
from
c64ab27 to
88584e5
Compare
cmaglie
changed the title
compile --only-compilation-database will run all pre-* hooks
cmaglie
force-pushed
the
fix-compile-db
branch
from
88584e5 to
bc4f7aa
Compare
umbynos
reviewed
Nov 16, 2021
per1234
requested changes
Nov 16, 2021
Co-authored-by: per1234 <accounts@perglass.com>
Co-authored-by: per1234 <accounts@perglass.com>
Co-authored-by: per1234 <accounts@perglass.com>
Co-authored-by: per1234 <accounts@perglass.com>
per1234
approved these changes
Nov 16, 2021
There was a problem hiding this comment.
I'm not knowledgeable about the compilation database subject, but I was able to reproduce #1547 for both esp32:esp32 and STMicroelectronics:stm32 boards platforms previously and am not able to reproduce it after the change proposed here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
UPGRADING.mdhas been updated with a migration guide (for breaking changes)To generate the "Compilation Database" some platforms requires to run the pre-build hooks to actually have a compilable target.
The pre-hooks are skipped.
The pre-hooks are now executed.
It may introduce some regression if a platform requires skipping pre-hooks to actually build a sketch. This is very unlikely BTW, since this would make fail also the full compile.
The post hooks and the compiler commands are still SKIPPED.
Fix #1547