Fix some commands crashing when an installed library has invalid version #1189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let the library index return the latest known version, if a library without a version is found. Signed-off-by: Ruben Jenster <r.jenster@drachenfels.de>
Signed-off-by: Ruben Jenster <r.jenster@drachenfels.de>
Signed-off-by: Ruben Jenster <r.jenster@drachenfels.de>
silvanocerza
changed the title
per1234
approved these changes
Feb 18, 2021
There was a problem hiding this comment.
Great work @r10r and @silvanocerza! I was able to reproduce #1176 before and everything is working nicely after.
I think you found a nice balance between providing resiliency while not going to unnecessary lengths to support non-compliant projects (e.g., creating an interpreter for versions so badly formed they can't even pass the very lenient "relaxed semver" requirement).
silvanocerza
added a commit
that referenced
this pull request
Feb 25, 2021
…ion (#1189) * librariesindex: Fix nil pointer. Refs #1176 Let the library index return the latest known version, if a library without a version is found. Signed-off-by: Ruben Jenster <r.jenster@drachenfels.de> * Remove logging statement from FindLibraryUpdate. Signed-off-by: Ruben Jenster <r.jenster@drachenfels.de> * Add a small comment to the lib.Version nil check. Signed-off-by: Ruben Jenster <r.jenster@drachenfels.de> * Fix some commands failing when an installed library has invalid version * [skip changelog] Add integration tests Co-authored-by: Ruben Jenster <r.jenster@drachenfels.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
UPGRADING.mdhas been updated with a migration guide (for breaking changes)Fixes a bug that caused several commands to crash.
Some commands crash with a
nilpointer dereference when an installed library has an invalid or empty version in itslibrary.propertiesfile.Installed libraries with invalid or empty version in
library.propertiesfile won't cause those commands to crash with anilpointer deference. Also if a library version can't be determined we assume it's outdated.titled accordingly?
No breaking changes here.
This PR includes commits from #1177, I had to cherry-pick them to a separate branch since they were commit to the fork's
masterbranch.Fixes #1176.
See how to contribute