Wifi connection menu with textual #3879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Torxed
approved these changes
Nov 1, 2025
Member
Torxed
left a comment
Torxed
left a comment
There was a problem hiding this comment.
Looks good, and good work on keeping it separated from the other UI stuff so we can swap/test stuff!
Member
|
I'll make a release to fix all the bugs, and then I'll merge this after that. |
Member
|
This is now released! 💣 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a bunch of new things, the primary goal was to introduce a new wifi connection menu to address #1634 . When implementing it it became clear that curses already has challenges with inputs of non ASCII characters which was "okay" for the existing inputs such as username and password configurations. But for existing wifi passwords that most likely contain a special character beyond ASCII it will not work. It could be run in raw mode but it would require more customisations and handling.
Therefore I opted to introduce textual https://textual.textualize.io. It currently lives alongside the curses implementation and is only used for the new Wifi connection menu which is only triggered if archinstall is run in offline mode and wpa_cli can be run/enabled successfully.
If this is a good way forward and accepted I will migrate existing menus over from curses to textual.