Skip to content

Conversation

@dee-fox
Copy link
Contributor

@dee-fox dee-fox commented Aug 30, 2025

PR Description:

Wraps access to the virtual DMI device in a try/except statement to not crash if it doesn't exist.

Tests and Checks

  • I have tested the code!

@dee-fox dee-fox requested a review from Torxed as a code owner August 30, 2025 02:13
@svartkanin
Copy link
Collaborator

The function shouldn't return some ambiguous string but rather none

@dee-fox
Copy link
Contributor Author

dee-fox commented Aug 31, 2025

yeah that works, checked on hardware

@svartkanin
Copy link
Collaborator

You'll need to update the types as well and handle it on the caller side

@dee-fox
Copy link
Contributor Author

dee-fox commented Sep 1, 2025

type updated, the one place this function is called seems to not really care about nulltypes (other bits of hardware.py are called in the same way and they may also return null)

@svartkanin svartkanin merged commit 1ef52f5 into archlinux:master Sep 8, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants