Add --skip-boot to allow for bypassing installation of a bootloader #3677
Conversation
| profile_config: ProfileConfiguration | None = None | ||
| mirror_config: MirrorConfiguration | None = None | ||
| network_config: NetworkConfiguration | None = None | ||
| bootloader: Bootloader = field(default=Bootloader.get_default()) |
There was a problem hiding this comment.
Had to remove this one in order to break a circular dependency from bootloader.py's get_default needing to access args in order to determine if None or default option should be returned.
There was a problem hiding this comment.
We're using a "No audio" option in the audio menu which is basically its own enum type. Would rhat pattern work here as well?
There was a problem hiding this comment.
That would work indeed, I can tweak that.
There was a problem hiding this comment.
But as its part of the enum now, can we revert this as its always going to be a Bootloader type again
|
I still need to check how |
|
Should this maybe just be a "No bootloader" option, maybe only visible via --advanced? |
|
True, maybe it just hides the option all together instead. Good thinking! |
…l setting it default to None to avoid it sneaking into the config file or being set behind the scenes causing if statements to trigger.
|
Some minor issues remain. 
The 
|
archinstall/lib/global_menu.py
Outdated
| ), | ||
| ] | ||
|
|
||
| if arch_config_handler.args.skip_boot: |
There was a problem hiding this comment.
Do we really want to omit the entire boot menu entry? I was under the impression the --skip-boot will enable the "No bootloader" option to be selected?
There was a problem hiding this comment.
Oh, my tired brain read:
"Should this maybe just be a "No bootloader" option"
As:
"maybe there shouldn't be a boot loader option"
I think the Bootloader.NO_BOOTLOADER option to be selected makes sense, I'll put the menu entry back :)
There was a problem hiding this comment.
All good, this should make the change much simpler :)
There was a problem hiding this comment.
Should be back now, waiting for ISO build to complete so I can test a full install.
…ault value to NO_BOOTLOADER when --skip-boot is present
|
Verified with three bootloaders, |
2 participants
This allows for workarounds in those semi-rare cases where the bootloader step would normally cause issues, allowing users to manually install one once the other steps are completed.