Skip to content

Fix 3626 #3536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Torxed merged 1 commit into from
May 29, 2025
Merged

Fix 3626 #3536

Torxed merged 1 commit into from
May 29, 2025

Conversation

@svartkanin
Copy link
Collaborator

@svartkanin svartkanin commented May 29, 2025 •
edited
Loading

Fixes #3526
Pointed the interactive section to the actual script in the examples/interactive_installation.py

@svartkanin svartkanin requested a review from Torxed as a code owner May 29, 2025 10:22
@Torxed Torxed merged commit 3359779 into archlinux:master May 29, 2025
8 checks passed
@codefiles
Copy link
Contributor

codefiles commented May 29, 2025 •
edited
Loading

The file that was linked to, examples/interactive_installation.py, is a symlink since 4c065c3. Following the newly added link on GitHub takes a user to a page that just has the contents ../archinstall/scripts/guided.py and a user would have to know to use the Symbolic Link hyperlink to get to the symlinked file. That adds an extra unnecessary step. Would it be better to link to the file it is symlinked to instead (guided.py)?

@svartkanin svartkanin mentioned this pull request May 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Torxed Torxed Torxed approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Example code in README has runtime errors

3 participants

@svartkanin @codefiles @Torxed