Skip to content

Conversation

@svartkanin
Copy link
Collaborator

@svartkanin svartkanin marked this pull request as ready for review May 5, 2025 07:04
@Torxed
Copy link
Member

Torxed commented May 5, 2025

Looks good.
I don't entirely agree with this comment: #3327 (comment)

We need a way to link packages we hard code in our profiles, to upstream PKGBUILD packages. Otherwise we're on our own in terms of keeping track of package removals/name changes etc.

And having optdepends is a hacky way for sure, but it's almost the only way currently to link us to packages, so that packagers can get notified about their changes.

@Torxed Torxed merged commit 9a98a15 into archlinux:master May 5, 2025
8 checks passed
@codefiles
Copy link
Contributor

codefiles commented May 5, 2025

Having them listed as optional dependencies implies that installing them on the host system will provide additional features to the archinstall package. That is not the case.

https://wiki.archlinux.org/title/PKGBUILD#optdepends

@Torxed
Copy link
Member

Torxed commented May 5, 2025

Having them listed as optional dependencies implies that installing them on the host system will provide additional features to the archinstall package. That is not the case.

https://wiki.archlinux.org/title/PKGBUILD#optdepends

I know, but again, due to the limitation of alpm and in extent pacman, after several discussions back and forth both on the Arch Linux summit as well as mailing lists and chat forums, this is basically our only option to link archinstall's internal package dependencies with actual package hooks that packagers use to keep track of their effect on certain changes.

But if you have a better idea of how to create this weak link, I'm all ears.
Because depends=() is too much of a strong link, as it will automatically drag in all packages if you install archinstall.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants