Use default EFI boot app path for Limine if installing to USB #3331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mintsuki
force-pushed
the
limine-removable-storage
branch
2 times, most recently
from
400928b to
16aa375
Compare
Contributor
Author
|
This is supposed to address #3325 by making it so the old bootloader install path is used for USB devices, while the new install method is kept for other (very very likely internal) devices. |
mintsuki
force-pushed
the
limine-removable-storage
branch
from
16aa375 to
ed702f6
Compare
mintsuki
changed the title
correctmost
reviewed
Apr 3, 2025
mintsuki
force-pushed
the
limine-removable-storage
branch
from
ed702f6 to
abafee3
Compare
correctmost
reviewed
Apr 3, 2025
Contributor
correctmost
left a comment
correctmost
left a comment
There was a problem hiding this comment.
Thanks for the updates, some minor comments below.
I will leave the official review to a maintainer :).
mintsuki
force-pushed
the
limine-removable-storage
branch
from
abafee3 to
a89a5b2
Compare
Contributor
Author
|
Thanks again, I fixed everything. |
svartkanin
approved these changes
Apr 3, 2025
Member
|
Great work everyone, I'm sure this will be greatly appreciated by a lot of people! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.