fix(installer): use platform.machine() for target architecture in grub-install #3320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Torxed
approved these changes
Mar 31, 2025
codefiles
reviewed
Apr 1, 2025
…b-install Signed-off-by: Zhou Qiankang <wszqkzqk@qq.com>
wszqkzqk
force-pushed
the
grub-install-arch
branch
from
ecaaddf to
e175b0b
Compare
Contributor
Author
|
Typo fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description:
Set GRUB target to
f'{platform.machine()}-efi'instead of hard-codedx86_64-efiin UEFI mode.Arch Linux devtools'
checkpkgalready suggests to use$CARCHinstead of hard-codedx86_64inPKGBUILD, so we may also follow it. This PR may be friendly to Arch Linux Ports (see the RFC) and has no negative impact on existing x86_64 architecture.According to the Arch Linux ports RFC:
So I only added the multi-architecture compatibility in UEFI mode. Architectures without UEFI support should be handled additionally according to the requirements of RFC.
/cc @felixonmars
Tests and Checks