Skip to content

Conversation

@hanslovsky
Copy link
Contributor

@hanslovsky hanslovsky commented Nov 27, 2018

This addresses multiple issues with Python jar linking:

Fixes only partially #22
Fixes #24
Fixes #25

@ctrueden do you have any objections against resolving #22 with a Python-only solution?

@ctrueden
Copy link
Member

Thanks @hanslovsky !

do you have any objections against resolving #22 with a Python-only solution?

I would prefer to implement it in the bash script as well. For now, just update issue #22 to say that the feature is now implemented in Python, and we'll close the issue as soon as the bash script catches up?

@hanslovsky hanslovsky mentioned this pull request Nov 28, 2018
@hanslovsky
Copy link
Contributor Author

cc05988 will close #22 but I will reopen

@hanslovsky hanslovsky merged commit 0e812f0 into master Nov 28, 2018
@hanslovsky hanslovsky deleted the fix-python-jar-linking branch November 28, 2018 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants