[registry]: add RegistryKeychainClient to the main client library#1215
Draft
saehejkang wants to merge 3 commits intoapple:mainfrom
Draft
[registry]: add RegistryKeychainClient to the main client library#1215saehejkang wants to merge 3 commits intoapple:mainfrom
saehejkang wants to merge 3 commits intoapple:mainfrom
Conversation
Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
saehejkang
commented
Feb 14, 2026
| throw ContainerizationError(.invalidArgument, message: "invalid host \(server)") | ||
| } | ||
|
|
||
| let client = RegistryClient( |
Contributor
Author
There was a problem hiding this comment.
Neglected to name the new client RegistryClient, because it is already defined like so in the containerization project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
Introduces the
RegistryKeychainClientto the main API client library. The client does not talk to the server and is more so an extraction of keychain/registry logic from the commands.Depends On
Waiting for #1195 to be merged, before marking this ready for review.
Testing