fix: --ssh flag for running containers (issue #1189)#1214
Open
chavezMac wants to merge 2 commits intoapple:mainfrom
Open
fix: --ssh flag for running containers (issue #1189)#1214chavezMac wants to merge 2 commits intoapple:mainfrom
chavezMac wants to merge 2 commits intoapple:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
[Why is this change needed?]
-Issue pointed out by @vibbix, when attempting to use the
--sshflag in thecontainer run ...command the value ofSSH_AUTH_SOCKwas not persisting and would result in a "The agent has no identities." as noted in the original issue.Following the how-to documentation, future users may run into this issue as well.
Root cause: The runtime helper is started by launchd (per-container plist), so it sees launchd’s environment, not the shell that ran
container run. The client’sSSH_AUTH_SOCK(e.g. from 1Password) was never passed into the container config, so the wrong socket was being used or no socket was used.Fix: The client now captures the caller’s
SSH_AUTH_SOCKwhen--sshis set and stores it in the container config. The sandbox service resolves the host socket with precedence: config → runtime env → launchctl, and mounts that path into the container so the correct agent is used across stop/logout/login/restart.Testing