Open
Conversation
In case of target directory doesn't exist, watch the parent directory first, and start watching the target directory if it is created. Throw error if parent directory doesn't exist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current DirectoryWatcher fails if
/etc/resolverdoes not exist. This PR fixes DirectoryWatcher to handle non-existing/etc/resolverdirectory. If that directory does not exist, it first watches/etcdirectory to check if/etc/resolverdirectory is created later. Once it detects new/etc/resolverdirectory, it starts watching new DNS resolver files there.This PR also fixes to log the exception thrown by API server's tasks.
Resolves #1207
Type of Change
Motivation and Context
In case of non-existing
/etc/resolverstarting API server fails.Testing