Fix persistent CI failures.#1205
Merged
katiewasnothere merged 2 commits intoapple:mainfrom Feb 13, 2026
Merged
Conversation
- CI build is failing because runners don't have an `/etc/resolver` directory, causing the directory monitor to fail. This occurs while the `install-kernel` make target is running, so it appears that kernel download is failing when it's just that the API server is dying. - Fixing the initial scan for the directory just moves the problem to the filesystem watch loop, likely because we're not testing the result of `open()` for errors. - Right now the priority is getting CI running and PRs merged, so just commenting out the realhost DNS server setup. - Also seeing that under some conditions it can take quite a while for launchd to start the helper for the default network (8 seconds or more). With the 10 second health check timeout after API server registration, this means that some CI runs can exhibit this failure mode. Added a `--timeout` option to SystemStart and set a 60 second timeout for install-kernel and integration Makefile targets. - Disabled `testNetworkCreateAndUse()` due to container bootstrap errors when trying to run the container immediately after creating the network. The slow network helper launch could be the reason behind the failures that drove us to serialize these tests.
jglogan
force-pushed
the
disable-realhostdns
branch
from
288eb32 to
24e8325
Compare
jglogan
force-pushed
the
disable-realhostdns
branch
from
43e3b19 to
b1db7b7
Compare
JaewonHur
approved these changes
Feb 13, 2026
Contributor
|
This resolves #1184. |
katiewasnothere
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
open()for errors.--timeoutoption to SystemStart and set a 60 second timeout for install-kernel and integration Makefile targets.--debugwas being placed in the wrong location in the api server startup args.Testing