Open
Conversation
JaewonHur
commented
Feb 12, 2026
| @echo Building container binaries... | ||
| @$(SWIFT) --version | ||
| @$(SWIFT) build -c $(BUILD_CONFIGURATION) $(SWIFT_CONFIGURATION) | ||
| @$(SWIFT) build -c $(BUILD_CONFIGURATION) $(SWIFT_CONFIGURATION) $(BUILD_OPTIONS) |
Contributor
Author
There was a problem hiding this comment.
Not sure it's a good approach.
Contributor
There was a problem hiding this comment.
For the pre-commit hook I added a separate swift-format config file for format-only checking. Could we use swift format in lint mode to do this, and then perhaps it's just a matter of adjusting the existing lint rule file?
swift-fmt-check:
@echo Applying the standard code formatting...
@$(SWIFT) format lint --recursive --strict --configuration .swift-format-nolint $(SWIFT_SRC)
Contributor
|
Thoughts on updating the |
Contributor
Author
|
Hi @saehejkang I'm not sure it might be merged to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
scripts/check-unused-imports.shwhich checks the unused imports in modified swift source files.Good to be used before making a pull request after modifying or creating lots of swift source files.
Type of Change
Motivation and Context
Developers can check and refine unused imports using this script, before making a PR.
Testing