docs: explain why uninstall script requires administrator password#1130
Closed
William-Laverty wants to merge 1 commit intoapple:mainfrom
Closed
docs: explain why uninstall script requires administrator password#1130William-Laverty wants to merge 1 commit intoapple:mainfrom
William-Laverty wants to merge 1 commit intoapple:mainfrom
Conversation
jglogan
requested changes
Feb 2, 2026
Contributor
jglogan
left a comment
jglogan
left a comment
There was a problem hiding this comment.
Looks good but see the comments and also, sign the commits. Thank you!
| exit 1 | ||
| fi | ||
|
|
||
| # Explain why administrator password is required |
Contributor
There was a problem hiding this comment.
I like the rewrite of the message. Once we merge the first PR, update this PR to wrap the EUID check around all of this
| echo " - Remove application files from ${INSTALL_DIR}" | ||
| echo " - Unregister the installer package receipt" | ||
| if [ "$DELETE_DATA" = true ]; then | ||
| echo " - Delete user data from ~/Library/Application Support" |
Contributor
There was a problem hiding this comment.
Suggested change
| echo " - Delete user data from ~/Library/Application Support" | |
| echo " - Delete user data from \"${HOME}/Library/Application Support\"" |
|
|
||
| # Explain why administrator password is required | ||
| echo "This script requires administrator privileges to:" | ||
| echo " - Remove application files from ${INSTALL_DIR}" |
Contributor
There was a problem hiding this comment.
Suggested change
| echo " - Remove application files from ${INSTALL_DIR}" | |
| echo " - Remove application files from \"${INSTALL_DIR}\"" |
William-Laverty
force-pushed
the
docs/explain-uninstall-password
branch
from
f03c802 to
29ac2ae
Compare
Addresses #1111 - Adds an informative message before sudo commands explaining: - Files are being removed from /usr/local - Package receipt needs to be unregistered - User data deletion (if -d flag is used) This helps users understand why their password is being requested.
William-Laverty
force-pushed
the
docs/explain-uninstall-password
branch
from
29ac2ae to
63c233f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #1111
Adds an informative message before the sudo commands in
uninstall-container.shexplaining why administrator privileges are required:/usr/localpkgutil --forget-dflag is used)Example Output
Testing
Tested locally to verify message displays correctly before password prompt.