You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Aug 14, 2020. It is now read-only.
The discovery specification does not meet the P2P download image now , this PR is for download images by P2P.
The proposal is rkt/rkt#1751 and the PR for rkt is rkt/rkt#1869
Hey @liugenping, thanks for the patch. I believe that the discovery semantics as they are today are sufficient to facilitate P2P. Since we do not prescribe a protocol (scheme) for the returned URL, discovery something can simply return something like a magnet URI - for example:
@jonboulle I think is ok.
1.Peer can get metadata(file name, pieces, pieces length, and hash) from other peers using bittrorrent extension( http://bittorrent.org/beps/bep_0009.html)
2. "tr=" should be retured in magnet URI as DHT is slowly
Are you happy for us to close this out then?
Alternatively, perhaps instead of this PR you could add an example of using the current meta tags to return a torrent reference?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The discovery specification does not meet the P2P download image now , this PR is for download images by P2P.
The proposal is rkt/rkt#1751 and the PR for rkt is rkt/rkt#1869