Replace keytar with @napi-rs/keyring for OS keychain access#7
Open
chocholous wants to merge 1 commit intoapify:mainfrom
Open
Replace keytar with @napi-rs/keyring for OS keychain access#7chocholous wants to merge 1 commit intoapify:mainfrom
chocholous wants to merge 1 commit intoapify:mainfrom
Conversation
keytar is deprecated and has persistent build issues with native modules across different platforms. @napi-rs/keyring is a modern, actively maintained alternative with prebuilt binaries via napi-rs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
keytarpackage with@napi-rs/keyringfor OS keychain accesskeytarhas persistent native module build issues across platforms;@napi-rs/keyringships prebuilt binaries via napi-rs and is actively maintainedChanges
src/lib/auth/keychain.ts— migrated fromkeytarasync API (keytar.setPassword/getPassword/deletePassword) to@napi-rs/keyringsync API (new Entry(service, account).setPassword/getPassword/deletePassword)package.json— replacedkeytar: ^7.9.0with@napi-rs/keyring: ^1.2.0Test plan
npm run buildpassesnpm test(unit + E2E) passes@napi-rs/keyringAPI: setPassword, getPassword, deletePassword all work correctly on macOSlibsecretlike keytar)🤖 Generated with Claude Code