feat!: Add headers in unique key computation #609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Please run the ci @vdusek. Thank you |
vdusek
requested changes
Oct 22, 2024
Collaborator
There was a problem hiding this comment.
Could you please use HttpHeaders type for headers? It should also help with the normalization. Otherwise, it looks solid.
vdusek
requested changes
Oct 22, 2024
Prathamesh010
force-pushed
the
feat-uniquekey
branch
from
04de7ae to
74465f3
Compare
Prathamesh010
force-pushed
the
feat-uniquekey
branch
from
74465f3 to
03091aa
Compare
Contributor
Author
|
The Requested changes are done. @vdusek Please have a look |
vdusek
changed the title
vdusek
approved these changes
Oct 23, 2024
Collaborator
vdusek
left a comment
vdusek
left a comment
There was a problem hiding this comment.
Hi @Prathamesh010, I made a few more changes there, otherwise it looks great. Thank you for your contribution.
1 task
Member
|
why was this marked as breaking change? |
Collaborator
The interface remained the same, but the computation of the extended unique key was changed. It will be released in 0.4 together with #542. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues
extended_unique_keycomputation #548Testing
Checklist