Skip to content

Conversation

@janbuchar
Copy link
Collaborator

@janbuchar janbuchar commented Jun 21, 2024

No description provided.

@janbuchar janbuchar added t-tooling Issues with this label are in the ownership of the tooling team. adhoc Ad-hoc unplanned task added during the sprint. labels Jun 21, 2024
@janbuchar janbuchar requested a review from vdusek June 21, 2024 09:55
@github-actions github-actions bot added this to the 92nd sprint - Tooling team milestone Jun 21, 2024
Copy link
Collaborator

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about a simple test case testing if it's called multiple times it always returns the object with the same ID? Or it's not necessary?

@janbuchar
Copy link
Collaborator Author

What about a simple test case testing if it's called multiple times it always returns the object with the same ID? Or it's not necessary?

Good point. Also we'll need to reset the global instance before each test, I guess.

@github-actions github-actions bot added the tested Temporary label used only programatically for some analytics. label Jun 24, 2024
@janbuchar janbuchar requested a review from vdusek June 24, 2024 09:10
Copy link
Collaborator

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a thought on the naming...

I suggest using get_global instead of get_global_configuration. Since the method serves as constructor for the Configuration class - including "configuration" in the method name seems redundant. Leaving it up to you.

Otherwise, LGTM.

@janbuchar
Copy link
Collaborator Author

I suggest using get_global instead of get_global_configuration. Since the method serves as constructor for the Configuration class - including "configuration" in the method name seems redundant. Leaving it up to you.

I was ready to tell you that it's named that way because of JS crawlee, but there it's called getGlobalConfig. I'm lost 😄

@janbuchar janbuchar merged commit e003aa6 into master Jun 24, 2024
@janbuchar janbuchar deleted the global-configuration-instance branch June 24, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants