feat: Add crawlee-cli option to skip project installation #1294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove `manual` value from package_manager option
github-actions
bot
added
t-tooling
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds a new option to control whether generated projects are automatically installed, updates templates and hooks to respect that option, and removes the now-unused manual package manager choice.
- Introduce
--install/--no-installflag tocreatecommand, with interactive prompting. - Wrap post-generation install steps in a Jinja conditional based on
install_project. - Update tests and template defaults to include
install_project.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/unit/test_cli.py | Added assertions and inputs for install_project in unit tests. |
| tests/e2e/project_template/test_static_crawlers_templates.py | Set install_project=False and remove accept_hooks override. |
| src/crawlee/project_template/hooks/post_gen_project.py | Wrapped Poetry/UV and pip install steps in install_project checks. |
| src/crawlee/project_template/cookiecutter.json | Dropped manual option and added install_project default. |
| src/crawlee/_cli.py | Added install_project CLI option, prompt logic, and messaging. |
Comments suppressed due to low confidence (1)
src/crawlee/_cli.py:160
- [nitpick] Consider updating the project documentation (e.g., README or CLI reference) to include the new
--install/--no-installoption so users know about this feature.
install_project: bool | None = typer.Option(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
crawlee-clioption to skip project installation - skips Python packages installation and Playwright installation.manualvalue from package_managercrawlee-clioptionIssues