Skip to content

Conversation

@baldasseva
Copy link
Collaborator

@baldasseva baldasseva commented Mar 24, 2025

The image sources as they are, are fetching the images from the root, i.e. https://crawlee.dev . Instead, we want them to fetch from crawlee python. There is namely one image that is different and has "Javascript" written on it (see if you can find it), but it should be "Python". The rest of the images are the same between js and py, so it doesn't matter as much.


I tested it with yarn start for the dev mode, and npx docusaurus build + npx docusaurus serve for a production-like build and in both cases the images are fetched correctly

@baldasseva baldasseva added adhoc Ad-hoc unplanned task added during the sprint. t-web Issues with this label are in the ownership of the web team. labels Mar 24, 2025
@baldasseva baldasseva requested review from B4nan and webrdaniel March 24, 2025 17:19
@baldasseva baldasseva self-assigned this Mar 24, 2025
@github-actions github-actions bot added this to the 111st sprint - Web Team milestone Mar 24, 2025
Copy link
Collaborator

@webrdaniel webrdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@B4nan B4nan merged commit ee7806f into master Mar 25, 2025
24 checks passed
@B4nan B4nan deleted the fix/wrong-homepage-image-source branch March 25, 2025 07:07
@B4nan
Copy link
Member

B4nan commented Mar 25, 2025

dang, this should have been docs commit too 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-web Issues with this label are in the ownership of the web team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants