Skip to content

refactor!: Replace enum with literal for EnqueueStrategy #1019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vdusek merged 6 commits into from
Feb 25, 2025
Merged

refactor!: Replace enum with literal for EnqueueStrategy #1019

vdusek merged 6 commits into from
Feb 25, 2025

Conversation

@vdusek
Copy link
Collaborator

@vdusek vdusek commented Feb 24, 2025 •
edited
Loading

@vdusek vdusek added t-tooling Issues with this label are in the ownership of the tooling team. adhoc Ad-hoc unplanned task added during the sprint. labels Feb 24, 2025
@vdusek vdusek added this to the 109th sprint - Tooling team milestone Feb 24, 2025
@vdusek vdusek self-assigned this Feb 24, 2025
@vdusek vdusek changed the title refactor!: Replace enum with literal for EnqueueStrategy refactor!: Replace enum with literal for EnqueueStrategy Feb 24, 2025
@github-actions github-actions bot added the tested Temporary label used only programatically for some analytics. label Feb 24, 2025
@vdusek vdusek mentioned this pull request Feb 24, 2025
Closed
janbuchar
janbuchar reviewed Feb 24, 2025
View reviewed changes
@vdusek vdusek requested a review from janbuchar February 25, 2025 08:06
janbuchar
janbuchar reviewed Feb 25, 2025
View reviewed changes
Copy link
Collaborator

@janbuchar janbuchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code seems well written - just a couple of comments to consider.

@vdusek vdusek requested a review from janbuchar February 25, 2025 12:43
@vdusek vdusek merged commit d2481ef into master Feb 25, 2025
23 checks passed
@vdusek vdusek deleted the enqueue-strategy branch February 25, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janbuchar janbuchar janbuchar approved these changes

@Pijukatel Pijukatel Awaiting requested review from Pijukatel

Assignees

@vdusek vdusek

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Milestone

109th sprint - Tooling team

Development

Successfully merging this pull request may close these issues.

3 participants

@vdusek @janbuchar