Use options manager for default row height and column width #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found you delayed the
\fwrite($sheetFilePointer, '<sheetData>');inWorksheetManager. But therefore invalid sheets will be generated if you simply call$writer->addNewSheetAndMakeItCurrent()without adding data to the worksheet.in my opinion
startSheetshould look like thisBut then there is no time to call
$writer->setDefaultColumnWidthor$writer->setDefaultRowHeightbefore the first sheet is created (byWriterMultiSheetsAbstract->openWriter()).Therefore i have refactored
setDefaultColumnWidthandsetDefaultRowHeightto use theOptionsManagerlikewriter->setTempFolder. I believe setting default values before the writer is opened is the easier way.