Enter "Reset Recvd" state when sending RESET_STREAM is acked

[masaori335]

To follow section 3.1.

Once a packet containing a RESET_STREAM has been acknowledged, the
sending part of the stream enters the "Reset Recvd" state, which is a
terminal state.
https://tools.ietf.org/html/draft-ietf-quic-transport-20#section-3.1

It looks like, there're piece of code, but not used correctly.

trafficserver/iocore/net/quic/QUICUnidirectionalStream.cc

Lines 350 to 357 in b7bf658

	void
	QUICSendStream::_on_frame_acked(QUICFrameInformationUPtr &info)
	{
	StreamFrameInfo *frame_info = nullptr;
	switch (info->type) {
	case QUICFrameType::RESET_STREAM:
	this->_is_reset_complete = true;
	break;

[maskit]

The code looks correct to me. What's wrong with it?

[masaori335]

It looks like the _is_reset_complete flag is not used. Because QUICTransferProgressProviderVIO::is_cancelled() always return false.

trafficserver/iocore/net/quic/QUICTransferProgressProvider.h

Lines 66 to 70 in b7bf658

	bool
	is_cancelled() const
	{
	return false;
	}

[maskit]

A reason QUICTransferProgressProviderVIO always returns false is that VIO doesn't have such a feature. So it's intentional.

Like I commented on Slack, QUICSendStream stream needs to maintain _is_reset_complete, and you would probably not be able to pass a QUICTransferProgressProviderVIO directly to a QUCStreamState object.

QUICTransferProgressProviderVIO is just hiding the detail of VIO stuff (e.g. ntodo, ndone).

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. Marking it stale to flag it for further consideration by the community.