Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Conversation

@qtweng
Copy link
Contributor

@qtweng qtweng commented Nov 4, 2021

This PR fixes #2770. A DNS hostname validation is added to httpBypassFqdn in Traffic Ops.


Which Traffic Control components are affected by this PR?

  • Traffic Ops

What is the best way to verify this PR?

Attempt to reproduce the original issue.

If this is a bugfix, which Traffic Control versions contained the bug?

  • 5.1
  • 6.0

PR submission checklist

@rawlinp rawlinp added bug something isn't working as intended Traffic Ops related to Traffic Ops labels Nov 4, 2021
@zrhoffman
Copy link
Member

In order for CI to pass, #6330 needs to be rebased onto the apache:master branch now that the CI fix in #6329 is merged:

git remote add apache git@github.com:apache/trafficcontrol.git
git fetch apache
git rebase apache
git push your-fork your-branch --force

Copy link
Contributor

@rawlinp rawlinp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just going to merge as-is since the CI failures are unrelated. I manually tested this validation, and it appears to work fine. Thanks @qtweng for your first contribution!

@rawlinp rawlinp merged commit 44f2f44 into apache:master Nov 4, 2021
@zrhoffman zrhoffman added this to the 6.0.1 milestone Nov 5, 2021
zrhoffman pushed a commit that referenced this pull request Nov 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug something isn't working as intended Traffic Ops related to Traffic Ops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Traffic Ops needs to validate httpBypassFqdn for HTTP Delivery Services

3 participants