SOLR-18080: Initiate Leader election for ShardTerms #4069
Conversation
| lastRecoveryTerm = lastTermDoRecovery.get(); | ||
| newTerm = terms.getTerm(coreNodeName); | ||
| if (lastRecoveryTerm < newTerm) { | ||
| lastTermDoRecovery.set(newTerm); |
There was a problem hiding this comment.
lastTermDoRecovery is set here but its possible recovery is deferred below because of leader election now. Is that right? The old logic set it, then actually does recovery regardless. Reading this, seems like there is a possibility that lastTermDoRecovery is set to the new term but can skip actually doing recovery further down. So the term this was set to is incorrect based on the name if recovery is skipped?
There was a problem hiding this comment.
Yeah lastTermDoRecovery might be a bad name, but after leader election, recovery is guaranteed for these replicas at this term value. So while recovery is not explicitly being done here, we know that leader election will do the recovery. So lastTermDoRecovery is still technically correct, just assuming the leader election succeeds.
2 participants
https://issues.apache.org/jira/browse/SOLR-18080
Whenever the shard terms change such that the leader is no longer the highest term, a leader election should take place, and all non-up-to-date replicas should go into recovery.