Skip to content

Conversation

@qsrg
Copy link
Contributor

@qsrg qsrg commented Mar 28, 2022

fix #99
Get consumer latency only when messageModel is clustering,otherwise boardcast consumer's latency is too large which cause trouble. Detail in issue.

@codecov-commenter
Copy link

Codecov Report

Merging #100 (e0709f5) into master (8bc34bc) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##             master    #100      +/-   ##
===========================================
- Coverage      0.35%   0.35%   -0.01%     
  Complexity        2       2              
===========================================
  Files            30      30              
  Lines          2242    2243       +1     
  Branches        195     196       +1     
===========================================
  Hits              8       8              
- Misses         2234    2235       +1     
Impacted Files Coverage Δ
...che/rocketmq/exporter/task/MetricsCollectTask.java 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bc34bc...e0709f5. Read the comment docs.

@qsrg qsrg changed the title fix: ignored latency for boardcast consumer fix: ignored rocketmq_group_get_latency_by_storetime for boardcast consumer Aug 10, 2022
@ShannonDing ShannonDing changed the title fix: ignored rocketmq_group_get_latency_by_storetime for boardcast consumer [ISSUE #100] ignored rocketmq_group_get_latency_by_storetime for boardcast consumer Nov 9, 2022
@ShannonDing ShannonDing changed the title [ISSUE #100] ignored rocketmq_group_get_latency_by_storetime for boardcast consumer [ISSUE #99] ignored rocketmq_group_get_latency_by_storetime for boardcast consumer Nov 9, 2022
@ShannonDing ShannonDing merged commit 5fb1de2 into apache:master Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The metric of rocketmq_group_get_latency_by_storetime should ignored for boardcast consumer

3 participants