[improve][broker] Enhance logging for adding schema failures in ServerCnx #25048
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dao-jun
approved these changes
Dec 9, 2025
poorbarcode
requested changes
Dec 9, 2025
| remoteAddress, | ||
| topicName, producerId, exception); | ||
| } | ||
| log.warn("Try add schema failed, remote address {}, topic {}, producerId {}", |
Contributor
There was a problem hiding this comment.
If the client-side makes a mistake, which registrers a incompatible schema, we should not print any warn log for it. In other words, IncompatibleSchemaException should be ignored
Member
Author
There was a problem hiding this comment.
If IncompatibleSchemaException should be ignored, then what about InvalidSchemaDataException? Does it also need to be ignored?
e.g
org.apache.pulsar.broker.service.schema.exceptions.InvalidSchemaDataException: Invalid schema definition data for PROTOBUF schema
at org.apache.pulsar.broker.service.schema.validator.StructSchemaDataValidator.throwInvalidSchemaDataException(StructSchemaDataValidator.java:98)
at org.apache.pulsar.broker.service.schema.validator.StructSchemaDataValidator.validate(StructSchemaDataValidator.java:69)
at org.apache.pulsar.broker.service.schema.validator.SchemaDataValidator.validateSchemaData(SchemaDataValidator.java:46)
at org.apache.pulsar.broker.service.schema.validator.SchemaRegistryServiceWithSchemaDataValidator.putSchemaIfAbsent(SchemaRegistryServiceWithSchemaDataValidator.java:92)
at org.apache.pulsar.broker.service.AbstractTopic.addSchema(AbstractTopic.java:729)
at org.apache.pulsar.broker.service.ServerCnx.tryAddSchema(ServerCnx.java:3185)
at org.apache.pulsar.broker.service.ServerCnx.lambda$handleProducer$32(ServerCnx.java:1721)
Member
Author
There was a problem hiding this comment.
Ignored InvalidSchemaDataException @poorbarcode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Since broker sent ErrorResponse to client when adding schema failed, so broker side only need to print warn log to help to troubleshoot the problem.
Modifications
The log level is changed from
errortowarn, and the conditional check forIncompatibleSchemaExceptionis removed, so all failures are now logged as warnings.Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: